Support cascade mappings
Change-Id: Ie20676b197a660babe69facb487d55af013af8c1
diff --git a/mapper/cascade_test.go b/mapper/cascade_test.go
new file mode 100644
index 0000000..998d437
--- /dev/null
+++ b/mapper/cascade_test.go
@@ -0,0 +1,338 @@
+package mapper
+
+import (
+ "encoding/json"
+ "testing"
+
+ "github.com/KorAP/Koral-Mapper/config"
+ "github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
+)
+
+// parseJSON is a test helper that unmarshals a JSON string.
+func parseJSON(t *testing.T, s string) any {
+ t.Helper()
+ var v any
+ require.NoError(t, json.Unmarshal([]byte(s), &v))
+ return v
+}
+
+func TestCascadeQueryTwoAnnotationMappings(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{
+ {
+ ID: "ann-step1", FoundryA: "opennlp", LayerA: "p",
+ FoundryB: "opennlp", LayerB: "p",
+ Mappings: []config.MappingRule{`[PIDAT] <> [DET]`},
+ },
+ {
+ ID: "ann-step2", FoundryA: "opennlp", LayerA: "p",
+ FoundryB: "upos", LayerB: "p",
+ Mappings: []config.MappingRule{`[DET] <> [PRON]`},
+ },
+ })
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{
+ "@type": "koral:token",
+ "wrap": {
+ "@type": "koral:term",
+ "foundry": "opennlp",
+ "key": "PIDAT",
+ "layer": "p",
+ "match": "match:eq"
+ }
+ }`)
+
+ result, err := m.CascadeQueryMappings(
+ []string{"ann-step1", "ann-step2"},
+ []MappingOptions{{Direction: AtoB}, {Direction: AtoB}},
+ input,
+ )
+ require.NoError(t, err)
+
+ expected := parseJSON(t, `{
+ "@type": "koral:token",
+ "wrap": {
+ "@type": "koral:term",
+ "foundry": "upos",
+ "key": "PRON",
+ "layer": "p",
+ "match": "match:eq"
+ }
+ }`)
+ assert.Equal(t, expected, result)
+}
+
+func TestCascadeQueryMixAnnotationAndCorpus(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{
+ {
+ ID: "ann-mapper", FoundryA: "opennlp", LayerA: "p",
+ FoundryB: "upos", LayerB: "p",
+ Mappings: []config.MappingRule{`[PIDAT] <> [DET]`},
+ },
+ {
+ ID: "corpus-mapper",
+ Type: "corpus",
+ Mappings: []config.MappingRule{`textClass=novel <> genre=fiction`},
+ },
+ })
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{
+ "query": {
+ "@type": "koral:token",
+ "wrap": {
+ "@type": "koral:term",
+ "foundry": "opennlp",
+ "key": "PIDAT",
+ "layer": "p",
+ "match": "match:eq"
+ }
+ },
+ "collection": {
+ "@type": "koral:doc",
+ "key": "textClass",
+ "value": "novel",
+ "match": "match:eq"
+ }
+ }`)
+
+ result, err := m.CascadeQueryMappings(
+ []string{"ann-mapper", "corpus-mapper"},
+ []MappingOptions{{Direction: AtoB}, {Direction: AtoB}},
+ input,
+ )
+ require.NoError(t, err)
+
+ resultMap := result.(map[string]any)
+
+ query := resultMap["query"].(map[string]any)
+ wrap := query["wrap"].(map[string]any)
+ assert.Equal(t, "DET", wrap["key"])
+ assert.Equal(t, "upos", wrap["foundry"])
+
+ collection := resultMap["collection"].(map[string]any)
+ assert.Equal(t, "genre", collection["key"])
+ assert.Equal(t, "fiction", collection["value"])
+}
+
+func TestCascadeQuerySingleElement(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{{
+ ID: "single", FoundryA: "opennlp", LayerA: "p",
+ FoundryB: "upos", LayerB: "p",
+ Mappings: []config.MappingRule{`[PIDAT] <> [DET]`},
+ }})
+ require.NoError(t, err)
+
+ makeInput := func() any {
+ return parseJSON(t, `{
+ "@type": "koral:token",
+ "wrap": {
+ "@type": "koral:term",
+ "foundry": "opennlp",
+ "key": "PIDAT",
+ "layer": "p",
+ "match": "match:eq"
+ }
+ }`)
+ }
+
+ opts := MappingOptions{Direction: AtoB}
+
+ cascadeResult, err := m.CascadeQueryMappings(
+ []string{"single"}, []MappingOptions{opts}, makeInput(),
+ )
+ require.NoError(t, err)
+
+ directResult, err := m.ApplyQueryMappings("single", opts, makeInput())
+ require.NoError(t, err)
+
+ assert.Equal(t, directResult, cascadeResult)
+}
+
+func TestCascadeQueryEmptyList(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{{
+ ID: "dummy", FoundryA: "x", LayerA: "y",
+ FoundryB: "a", LayerB: "b",
+ Mappings: []config.MappingRule{`[X] <> [Y]`},
+ }})
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{
+ "@type": "koral:token",
+ "wrap": {"@type": "koral:term", "key": "Z"}
+ }`)
+
+ result, err := m.CascadeQueryMappings(nil, nil, input)
+ require.NoError(t, err)
+ assert.Equal(t, input, result)
+}
+
+func TestCascadeQueryUnknownID(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{{
+ ID: "known", FoundryA: "x", LayerA: "y",
+ FoundryB: "a", LayerB: "b",
+ Mappings: []config.MappingRule{`[X] <> [Y]`},
+ }})
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{
+ "@type": "koral:token",
+ "wrap": {"@type": "koral:term", "key": "X"}
+ }`)
+
+ _, err = m.CascadeQueryMappings(
+ []string{"known", "nonexistent"},
+ []MappingOptions{{Direction: AtoB}, {Direction: AtoB}},
+ input,
+ )
+ assert.Error(t, err)
+ assert.Contains(t, err.Error(), "nonexistent")
+}
+
+// --- Response cascade tests ---
+
+func TestCascadeResponseTwoCorpusMappings(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{
+ {
+ ID: "corpus-step1", Type: "corpus",
+ Mappings: []config.MappingRule{`textClass=novel <> genre=fiction`},
+ },
+ {
+ ID: "corpus-step2", Type: "corpus",
+ Mappings: []config.MappingRule{`genre=fiction <> category=lit`},
+ },
+ })
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{
+ "fields": [{
+ "@type": "koral:field",
+ "key": "textClass",
+ "value": "novel",
+ "type": "type:string"
+ }]
+ }`)
+
+ result, err := m.CascadeResponseMappings(
+ []string{"corpus-step1", "corpus-step2"},
+ []MappingOptions{{Direction: AtoB}, {Direction: AtoB}},
+ input,
+ )
+ require.NoError(t, err)
+
+ fields := result.(map[string]any)["fields"].([]any)
+ require.GreaterOrEqual(t, len(fields), 3)
+
+ assert.Equal(t, "textClass", fields[0].(map[string]any)["key"])
+
+ assert.Equal(t, "genre", fields[1].(map[string]any)["key"])
+ assert.Equal(t, "fiction", fields[1].(map[string]any)["value"])
+
+ assert.Equal(t, "category", fields[2].(map[string]any)["key"])
+ assert.Equal(t, "lit", fields[2].(map[string]any)["value"])
+}
+
+func TestCascadeResponseMixAnnotationAndCorpus(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{
+ {
+ ID: "ann-resp", FoundryA: "opennlp", LayerA: "p",
+ FoundryB: "upos", LayerB: "p",
+ Mappings: []config.MappingRule{`[DET] <> [PRON]`},
+ },
+ {
+ ID: "corpus-resp",
+ Type: "corpus",
+ Mappings: []config.MappingRule{`textClass=novel <> genre=fiction`},
+ },
+ })
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{
+ "snippet": "<span title=\"opennlp/p:DET\">Der</span>",
+ "fields": [{
+ "@type": "koral:field",
+ "key": "textClass",
+ "value": "novel",
+ "type": "type:string"
+ }]
+ }`)
+
+ result, err := m.CascadeResponseMappings(
+ []string{"ann-resp", "corpus-resp"},
+ []MappingOptions{{Direction: AtoB}, {Direction: AtoB}},
+ input,
+ )
+ require.NoError(t, err)
+
+ resultMap := result.(map[string]any)
+
+ snippet := resultMap["snippet"].(string)
+ assert.Contains(t, snippet, "opennlp/p:DET")
+ assert.Contains(t, snippet, "upos/p:PRON")
+
+ fields := resultMap["fields"].([]any)
+ require.GreaterOrEqual(t, len(fields), 2)
+ assert.Equal(t, "genre", fields[1].(map[string]any)["key"])
+}
+
+func TestCascadeResponseSingleElement(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{{
+ ID: "corpus-single", Type: "corpus",
+ Mappings: []config.MappingRule{`textClass=novel <> genre=fiction`},
+ }})
+ require.NoError(t, err)
+
+ makeInput := func() any {
+ return parseJSON(t, `{
+ "fields": [{
+ "@type": "koral:field",
+ "key": "textClass",
+ "value": "novel",
+ "type": "type:string"
+ }]
+ }`)
+ }
+
+ opts := MappingOptions{Direction: AtoB}
+
+ cascadeResult, err := m.CascadeResponseMappings(
+ []string{"corpus-single"}, []MappingOptions{opts}, makeInput(),
+ )
+ require.NoError(t, err)
+
+ directResult, err := m.ApplyResponseMappings("corpus-single", opts, makeInput())
+ require.NoError(t, err)
+
+ assert.Equal(t, directResult, cascadeResult)
+}
+
+func TestCascadeResponseEmptyList(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{{
+ ID: "dummy", Type: "corpus",
+ Mappings: []config.MappingRule{`x=y <> a=b`},
+ }})
+ require.NoError(t, err)
+
+ input := parseJSON(t, `{"fields": []}`)
+
+ result, err := m.CascadeResponseMappings(nil, nil, input)
+ require.NoError(t, err)
+ assert.Equal(t, input, result)
+}
+
+func TestCascadeResponseUnknownID(t *testing.T) {
+ m, err := NewMapper([]config.MappingList{{
+ ID: "known", Type: "corpus",
+ Mappings: []config.MappingRule{`x=y <> a=b`},
+ }})
+ require.NoError(t, err)
+
+ _, err = m.CascadeResponseMappings(
+ []string{"nonexistent"},
+ []MappingOptions{{Direction: AtoB}},
+ parseJSON(t, `{"fields": []}`),
+ )
+ assert.Error(t, err)
+ assert.Contains(t, err.Error(), "nonexistent")
+}
diff --git a/mapper/mapper.go b/mapper/mapper.go
index e55e77a..4869c7b 100644
--- a/mapper/mapper.go
+++ b/mapper/mapper.go
@@ -103,3 +103,43 @@
Direction Direction
AddRewrites bool
}
+
+// CascadeQueryMappings applies multiple mapping lists sequentially,
+// feeding the output of each into the next. orderedIDs and
+// perMappingOpts must have the same length. An empty list returns
+// jsonData unchanged.
+func (m *Mapper) CascadeQueryMappings(orderedIDs []string, perMappingOpts []MappingOptions, jsonData any) (any, error) {
+ if len(orderedIDs) != len(perMappingOpts) {
+ return nil, fmt.Errorf("orderedIDs length (%d) must match perMappingOpts length (%d)", len(orderedIDs), len(perMappingOpts))
+ }
+
+ result := jsonData
+ for i, id := range orderedIDs {
+ var err error
+ result, err = m.ApplyQueryMappings(id, perMappingOpts[i], result)
+ if err != nil {
+ return nil, fmt.Errorf("cascade step %d (mapping %q): %w", i, id, err)
+ }
+ }
+ return result, nil
+}
+
+// CascadeResponseMappings applies multiple mapping lists sequentially
+// to a response object, feeding the output of each into the next.
+// orderedIDs and perMappingOpts must have the same length. An empty
+// list returns jsonData unchanged.
+func (m *Mapper) CascadeResponseMappings(orderedIDs []string, perMappingOpts []MappingOptions, jsonData any) (any, error) {
+ if len(orderedIDs) != len(perMappingOpts) {
+ return nil, fmt.Errorf("orderedIDs length (%d) must match perMappingOpts length (%d)", len(orderedIDs), len(perMappingOpts))
+ }
+
+ result := jsonData
+ for i, id := range orderedIDs {
+ var err error
+ result, err = m.ApplyResponseMappings(id, perMappingOpts[i], result)
+ if err != nil {
+ return nil, fmt.Errorf("cascade step %d (mapping %q): %w", i, id, err)
+ }
+ }
+ return result, nil
+}