commit 4718aace48c709d92509d9ff4c6578de99cea294
author Marc Kupietz <kupietz@ids-mannheim.de> Wed Sep 24 14:42:03 2025 +0200
committer Marc Kupietz <kupietz@ids-mannheim.de> Wed Sep 24 14:42:03 2025 +0200
tree e6717793b25703af51e659eb113849204f1e28ae
parent 51aedc6ac5887cd12e19454509cf9e1ab05e3b09

Fix assert argument order in OAuth2PluginTest

Change-Id: I4b4449e3a288465d830b7f6c31ec97038cc9d18c

src/test/java/de/ids_mannheim/korap/web/controller/OAuth2PluginTest.java

diff --git a/src/test/java/de/ids_mannheim/korap/web/controller/OAuth2PluginTest.java b/src/test/java/de/ids_mannheim/korap/web/controller/OAuth2PluginTest.java
index 301055e..de4850b 100644
--- a/src/test/java/de/ids_mannheim/korap/web/controller/OAuth2PluginTest.java
+++ b/src/test/java/de/ids_mannheim/korap/web/controller/OAuth2PluginTest.java
@@ -116,7 +116,7 @@
             throws ProcessingException, KustvaktException {
         JsonNode clientInfo = retrieveClientInfo(clientId, "other-user");
         assertEquals(clientId, clientInfo.at("/client_id").asText());
-        assertEquals(clientInfo.at("/client_name").asText(), "Plugin");
+        assertEquals("Plugin", clientInfo.at("/client_name").asText());
         assertEquals(OAuth2ClientType.CONFIDENTIAL.name(),
                 clientInfo.at("/client_type").asText());
         assertNotNull(clientInfo.at("/client_description").asText());
@@ -385,9 +385,9 @@
         Response response = installPlugin(form);
         String entity = response.readEntity(String.class);
         JsonNode node = JsonUtils.readTree(entity);
-        assertEquals(node.at("/error_description").asText(),
-                "Unknown client: unknown");
-        assertEquals(node.at("/error").asText(), "invalid_client");
+        assertEquals("Unknown client: unknown",
+            node.at("/error_description").asText());
+        assertEquals("invalid_client", node.at("/error").asText());
         assertEquals(Status.UNAUTHORIZED.getStatusCode(), response.getStatus());
     }
 
@@ -399,9 +399,9 @@
         Response response = installPlugin(form);
         String entity = response.readEntity(String.class);
         JsonNode node = JsonUtils.readTree(entity);
-        assertEquals(node.at("/error_description").asText(),
-                "Missing parameter: super_client_secret");
-        assertEquals(node.at("/error").asText(), "invalid_request");
+        assertEquals("Missing parameter: super_client_secret",
+            node.at("/error_description").asText());
+        assertEquals("invalid_request", node.at("/error").asText());
         assertEquals(Status.BAD_REQUEST.getStatusCode(), response.getStatus());
     }
 
@@ -412,9 +412,9 @@
         Response response = installPlugin(form);
         String entity = response.readEntity(String.class);
         JsonNode node = JsonUtils.readTree(entity);
-        assertEquals(node.at("/error_description").asText(),
-                "Missing parameter: super_client_id");
-        assertEquals(node.at("/error").asText(), "invalid_request");
+        assertEquals("Missing parameter: super_client_id",
+            node.at("/error_description").asText());
+        assertEquals("invalid_request", node.at("/error").asText());
         assertEquals(Status.BAD_REQUEST.getStatusCode(), response.getStatus());
     }
 
@@ -427,7 +427,7 @@
         Response response = installPlugin(form);
         String entity = response.readEntity(String.class);
         JsonNode node = JsonUtils.readTree(entity);
-        assertEquals(node.at("/error").asText(), "unauthorized_client");
+        assertEquals("unauthorized_client", node.at("/error").asText());
         assertEquals(Status.UNAUTHORIZED.getStatusCode(), response.getStatus());
     }