commit ef1883fe451e28e1f5045368dbabf8ae3d49a1e0
author margaretha <margaretha@ids-mannheim.de> Wed May 25 12:24:12 2022 +0200
committer margaretha <margaretha@ids-mannheim.de> Wed May 25 12:24:12 2022 +0200
tree c8d4725d5aaacfbd30c150c6ea200b66f5c49a9b
parent 0034a0c3178815bab42b6e5df46776e3b41ddc1b

Fixed null client_id.

Change-Id: I4d1ac3609381c53e475e33237f4e5dc940ce34e0

full/Changes

diff --git a/full/Changes b/full/Changes
index a5a1ddc..abfa4f0 100644
--- a/full/Changes
+++ b/full/Changes
@@ -3,6 +3,8 @@
 2022-05-12
  - Implemented mapping of LDAP username to email
  - Handled null parameters in authorization requests
+2022-05-25
+ - Fixed null client_id
 
 # version 0.67
 

full/src/main/java/de/ids_mannheim/korap/oauth2/oltu/service/OltuAuthorizationService.java

diff --git a/full/src/main/java/de/ids_mannheim/korap/oauth2/oltu/service/OltuAuthorizationService.java b/full/src/main/java/de/ids_mannheim/korap/oauth2/oltu/service/OltuAuthorizationService.java
index a3b9b01..0ac3da6 100644
--- a/full/src/main/java/de/ids_mannheim/korap/oauth2/oltu/service/OltuAuthorizationService.java
+++ b/full/src/main/java/de/ids_mannheim/korap/oauth2/oltu/service/OltuAuthorizationService.java
@@ -108,7 +108,7 @@
 
     public OAuthProblemException checkRedirectUri (OAuthProblemException e,
             String clientId, String redirectUri) {
-        if (!clientId.isEmpty()) {
+        if (clientId !=null && !clientId.isEmpty()) {
             String registeredUri = null;
             try {
                 OAuth2Client client = clientService.retrieveClient(clientId);