Remove redundant thresholdScore parameter from add_multi_vc_comparisons function
Change-Id: I3a0077497f52d94e0b63d90bca0812c7e3d0c9d6
diff --git a/R/collocationAnalysis.R b/R/collocationAnalysis.R
index b7c5be6..69d2208 100644
--- a/R/collocationAnalysis.R
+++ b/R/collocationAnalysis.R
@@ -196,7 +196,6 @@
multi_result |>
add_multi_vc_comparisons(
- thresholdScore = thresholdScore,
missingScoreQuantile = missingScoreQuantile
)
}
@@ -316,7 +315,7 @@
return(res)
}
-add_multi_vc_comparisons <- function(result, thresholdScore, missingScoreQuantile = 0.05) {
+add_multi_vc_comparisons <- function(result, missingScoreQuantile = 0.05) {
label <- node <- collocate <- NULL
if (!"label" %in% names(result) || dplyr::n_distinct(result$label) < 2) {
diff --git a/tests/testthat/test-collocations.R b/tests/testthat/test-collocations.R
index f79cf50..7ab1b22 100644
--- a/tests/testthat/test-collocations.R
+++ b/tests/testthat/test-collocations.R
@@ -121,7 +121,7 @@
pmi = c(2, 3)
)
- enriched <- RKorAPClient:::add_multi_vc_comparisons(sample_result, "logDice")
+ enriched <- RKorAPClient:::add_multi_vc_comparisons(sample_result)
expect_true(all(c(
"winner_logDice",
@@ -198,7 +198,7 @@
pmi = c(2, 3, 1)
)
- enriched <- RKorAPClient:::add_multi_vc_comparisons(sample_result, "logDice")
+ enriched <- RKorAPClient:::add_multi_vc_comparisons(sample_result)
expect_equal(enriched$winner_logDice[1], "B")
expect_equal(enriched$winner_logDice_value[1], 8)
expect_equal(enriched$runner_up_logDice[1], "A")
@@ -239,7 +239,7 @@
)
)
- enriched <- RKorAPClient:::add_multi_vc_comparisons(base_tbl, "logDice")
+ enriched <- RKorAPClient:::add_multi_vc_comparisons(base_tbl)
target_row <- enriched |>
dplyr::filter(collocate == "c1") |>
dplyr::slice_head(n = 1)
@@ -274,7 +274,7 @@
logDice = c(5, NA)
)
- enriched <- RKorAPClient:::add_multi_vc_comparisons(sample_result, "logDice")
+ enriched <- RKorAPClient:::add_multi_vc_comparisons(sample_result)
expect_equal(enriched$rank_A_logDice[1], 1)
expect_true(is.na(enriched$rank_B_logDice[1]))
@@ -306,7 +306,6 @@
enriched <- RKorAPClient:::add_multi_vc_comparisons(
sample_result,
- "logDice",
missingScoreQuantile = 0.05
)