tree 2dd3bcb6ed29c405d3f6fcf56adce6daae2bdfab
parent b61a72a726f10b555057f4ffd6173ddb32e560e0
author Marc Kupietz <kupietz@ids-mannheim.de> 1785457077 +0900
committer Marc Kupietz <kupietz@ids-mannheim.de> 1785457077 +0900

Fix two memory leaks in the collocator lookup

Every collocator lookup leaked a rocksdb iterator and 80 bytes of window sums:

CollocatorIterator takes the iterator that SeekIterator() gets from
DB::NewIterator(), but had no destructor, so the compiler generated one that
does not touch the raw pointer. The wrapper was deleted by its unique_ptr, the
iterator it wrapped was not, together with everything it pins.

get_collocators() allocated its fixed size sumWindow array with malloc() and
never freed it. It is a fixed size, so it lives on the stack now.

Measured with 20000 calls of get_collocators_as_json() on the test database:
3.63 kB per call before, no measurable growth at all afterwards. The 80 bytes
were per call regardless of the result size, which is what gave them away.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Change-Id: I1b1148ada81bd821784b8e327334fc3bafe29e1b